feat(avm): gas mutations #19348
Open
feat(avm): gas mutations #19348
+242
−116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 6, 2026
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
IlyasRidhuan
force-pushed
the
ir/01-05-feat_avm_gas_mutations
branch
from
7b56b51 to
93eb5a8
Compare
IlyasRidhuan
force-pushed
the
ir/01-04-feat_avm_mutations_for_accumulated_data
branch
from
e8578e9 to
ae09b1d
Compare
IlyasRidhuan
force-pushed
the
ir/01-05-feat_avm_gas_mutations
branch
from
93eb5a8 to
aa96990
Compare
IlyasRidhuan
force-pushed
the
ir/01-04-feat_avm_mutations_for_accumulated_data
branch
2 times, most recently
from
3c26110 to
d291430
Compare
IlyasRidhuan
force-pushed
the
ir/01-05-feat_avm_gas_mutations
branch
from
aa96990 to
3700f20
Compare
IlyasRidhuan
force-pushed
the
ir/01-04-feat_avm_mutations_for_accumulated_data
branch
from
d291430 to
c282ab6
Compare
IlyasRidhuan
force-pushed
the
ir/01-05-feat_avm_gas_mutations
branch
2 times, most recently
from
3d86939 to
d39d11f
Compare
IlyasRidhuan
force-pushed
the
ir/01-04-feat_avm_mutations_for_accumulated_data
branch
from
c282ab6 to
40f1713
Compare
IlyasRidhuan
force-pushed
the
ir/01-04-feat_avm_mutations_for_accumulated_data
branch
from
40f1713 to
fd2d950
Compare
IlyasRidhuan
force-pushed
the
ir/01-05-feat_avm_gas_mutations
branch
2 times, most recently
from
4168739 to
6f984cd
Compare
IlyasRidhuan
force-pushed
the
ir/01-04-feat_avm_mutations_for_accumulated_data
branch
from
fd2d950 to
5420487
Compare
IlyasRidhuan
changed the base branch from
ir/01-04-feat_avm_mutations_for_accumulated_data
to
graphite-base/19348
IlyasRidhuan
force-pushed
the
ir/01-05-feat_avm_gas_mutations
branch
from
6f984cd to
fbabbed
Compare
IlyasRidhuan
force-pushed
the
graphite-base/19348
branch
from
5420487 to
7e7dc6e
Compare
IlyasRidhuan
changed the base branch from
graphite-base/19348
to
ir/01-04-feat_avm_mutations_for_accumulated_data
IlyasRidhuan
changed the base branch from
ir/01-04-feat_avm_mutations_for_accumulated_data
to
graphite-base/19348
IlyasRidhuan
force-pushed
the
ir/01-05-feat_avm_gas_mutations
branch
from
fbabbed to
ac33049
Compare
IlyasRidhuan
force-pushed
the
graphite-base/19348
branch
from
7e7dc6e to
445b83c
Compare
IlyasRidhuan
commented
Jan 9, 2026
| // | ||
| // Gas bounds for mutation | ||
| constexpr uint32_t MIN_GAS = 0; | ||
| constexpr uint32_t AVM_MAX_PROCESSABLE_DA_GAS = (MAX_NOTE_HASHES_PER_TX * AVM_EMITNOTEHASH_BASE_DA_GAS) + |
Contributor
Author
There was a problem hiding this comment.
This might not be 100% right, but probably ballpark? @sirasistant
Contributor
There was a problem hiding this comment.
yeah should be close enough
IlyasRidhuan
commented
Jan 9, 2026
| case TxMutationOptions::GasUsedByPrivate: | ||
| // Mutate gas_used_by_private | ||
| fuzz_info("Mutating gas used by private"); | ||
| mutate_gas(tx.gas_used_by_private, rng); |
Contributor
Author
There was a problem hiding this comment.
do i need to check that this value is < gas_limits ? Or is it worthwhile trying out scenarios where this is not true?
Contributor
There was a problem hiding this comment.
As an improvement, we might want to generate taking into account the limit instead of generate + clamp, or we we'll overrepresent gas used by private == limit
Contributor
There was a problem hiding this comment.
or we could just generate it and then do modulo the limit
IlyasRidhuan
force-pushed
the
graphite-base/19348
branch
from
445b83c to
2308b5b
Compare
IlyasRidhuan
force-pushed
the
ir/01-05-feat_avm_gas_mutations
branch
from
ac33049 to
193d8a7
Compare
IlyasRidhuan
changed the base branch from
graphite-base/19348
to
merge-train/avm
IlyasRidhuan
force-pushed
the
ir/01-05-feat_avm_gas_mutations
branch
from
193d8a7 to
3faa9e2
Compare
sirasistant
approved these changes
Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mutations for gas-related fields in the tx (including gasUsedByPrivate, and Feepayer)